Making GreenButton Parser accessible as a gem.

cew821 / greenbutton

A Green Button data parser written in Ruby

MIT License

20 stars 9 forks source link

Making GreenButton Parser accessible as a gem. #1

Closed sandeepkunkunuru closed 10 years ago

sandeepkunkunuru commented 10 years ago

Adding a gemspec file to make it accessible as a gem
Renamed parser.rb to greenbutton.rb to make it easier to resolve module name to source file. Referece: http://stackoverflow.com/questions/11525350/uninitialized-constant-error-when-including-a-module
Tested it as local path gem library as follows:

gem 'greenbutton', :path => '/home/kunkunur/dev/prototype/greenbutton'

The below should work as well

gem 'greenbutton', :path => 'https://github.com/sandeepkunkunuru/greenbutton'

cew821 commented 10 years ago

Hi Sandeep - thanks a bunch for this! I've never packaged a gem before. One question: do we need to include nokogiri as a dependency as well as rspec?

sandeepkunkunuru commented 10 years ago

No problem Charles. Happy to do it. This is my first gem package as well.Yes, nokogiri should also be added as a dependency. I added it.

cew821 commented 10 years ago

Hi Sandeep - There have been some big changes to the library (including the ability to parse the full spectrum of green button data entry types). Can you check out the latest master? Curious to get your feedback on whether this works for your project.

Closing this pull request for now, but please feel free to submit changes on the new master, as I think it is approaching something a bit more stable.