cexplorer / cexplorer.io

website features, implementations, docs
23 stars 15 forks source link

Full pool names don't always fit image title #10

Closed rphair closed 2 years ago

rphair commented 2 years ago

Our pool name Centre for Open Systems Deployment, especially its last long word Deployment, does not fit as a title for the graphical epoch summary distributed through the Cexplorer bot:

COSD banner, last word Deployment truncated

To reproduce: subscribe to our pool with the Cexplorer bot, select "Epoch Summary" (?) notifications, and wait to see an image like this in the Telegram bot message. This may also appear in other sharing contexts... the web site is down at this moment so we can't check.

Expected behaviour: layout should probably compress font size on top line, so additional lines don't push the rest of the graphics down.

Additional context Newman & I (@COSDpool) had a dialogue by Telegram PM in January 2021 that discussed various ways of proportionally fitting text to fix a prior AdaPools layout problem.

rphair commented 2 years ago

p.s. web site back up now: as suspected, we have a problem with the corresponding pool banner on the Share page, which uses the same text spacing for the graphical title (i.e. the last word of our pool name "Deployment" is also omitted): https://js.cexplorer.io/img/p-b-1/pool1e98xlcgj80c3rdmm27v5hnvrdtut52e65uk0ema7ctfag596vr2.jpg

pool1e98xlcgj80c3rdmm27v5hnvrdtut52e65uk0ema7ctfag596vr2

Also we can see here the pool subtitle, which in our case contains & to display as valid HTML in most contexts, is not interpreted correctly as & as it would be on Daedalus & other pool listings. Expected Behaviour: for *& to map to & before any text processing. 🙏

cexplorer commented 2 years ago

Thank you @rphair.

Fixes should be on the way and changes applied very soon :)

rphair commented 2 years ago

thanks; I can confirm both the Telegram delivered image and the downloadable banner have our pool title fit properly to the margin 🤓