search

ceylon / ceylon-common

DEPRECATED
Apache License 2.0
14 stars 9 forks source link

Enforce UTF-8 file encoding for javac #40

Closed lucaswerkmeister closed 10 years ago

lucaswerkmeister commented 10 years ago

@djadmin had build problems, hopefully this should fix them.

https://groups.google.com/d/msg/ceylon-users/H2Es65dZSks/zXFeOyh64dUJ

@djadmin could you test this? Run

git remote add lucaswerkmeister 'https://github.com/lucaswerkmeister/ceylon-common.git'
git fetch lucaswerkmeister
git checkout enforceUtf8
ant clean build

and tell me if it works

FroMage commented 10 years ago

Thanks.

lucaswerkmeister commented 10 years ago

Wait, I have no idea if this even works! I wasn’t able to reproduce the error even when enforcing ASCII encoding.

FroMage commented 10 years ago

The fix is in line with the encoding we set in the other projects, so it should be good.

lucaswerkmeister commented 10 years ago

Alright…

djadmin commented 10 years ago

Now, It works like a charm. Thanks

lucaswerkmeister commented 10 years ago

The fix is in line with the encoding we set in the other projects, so it should be good.

Oh, I didn’t see that you were already doing this in the other projects.