search

ceylon / ceylon-module-resolver

DEPRECATED
Apache License 2.0
23 stars 9 forks source link

Concurrency issues with `ByteCodeUtils.readModuleInfo()` #101

Closed quintesse closed 10 years ago

alesj commented 10 years ago

This can be more optimised. ;)

On Sep 21, 2014, at 20:10, Tako Schotanus notifications@github.com wrote:

Closed #101 via df91db7.

— Reply to this email directly or view it on GitHub.

quintesse commented 10 years ago

Yes, and it doesn't even fix the problem :(

alesj commented 10 years ago

@quintesse let me know if you need any help. ;-)

quintesse commented 10 years ago

Ok, right now I'm not even sure what the simplest way is to trigger this problem. I can only do it when rebuilding the entire distribution. But when I just delete the .idx files it doesn't happen. So it might be something else entirely.

alesj commented 10 years ago

We could add Byteman to help us reproduce this -- if it's a concurrency issue.

On Sep 22, 2014, at 0:23, Tako Schotanus notifications@github.com wrote:

Ok, right now I'm not even sure what the simplest way is to trigger this problem. I can only do it when rebuilding the entire distribution. But when I just delete the .idx files it doesn't happen. So it might be something else entirely.

— Reply to this email directly or view it on GitHub.

quintesse commented 10 years ago

I have no idea what Byteman is :) But I'm still trying to see if it's really a concurrency issue.

quintesse commented 10 years ago

Ok, I obviously shouldn't try to do smart concurrency stuff :( I finally fixed by just making the method synchronized which is obviously not the most efficient way. Btw, the indexer doesn't let you specify the output file which means that multiple concurrent JVMs could still mess each other up (I'd first generate it to a temp file and then rename it at the very end)