ceylon / ceylon-module-resolver

DEPRECATED
Apache License 2.0
23 stars 9 forks source link

Ceylon maven improvements #131

Open vietj opened 8 years ago

vietj commented 8 years ago

there are a few issues with this code:

quintesse commented 8 years ago

With "this code" I assume you refer to the maven-support JAR?

quintesse commented 8 years ago

The issue also doesn't make very clear what the proposed improvements are, I assume:

Right?

But I'm not sure what the problem is with the class loader? And that problem would not be fixed by using Aether directly? So what would you propose to do about it?

alesj commented 8 years ago

it uses Arquillian facade and it could use directly Aether

Aether API must be one of the worst to work with, hence I chose the lesser evil -- ShrinkWarp over Aether. But feel free to change it.

vietj commented 8 years ago

@quintesse yes both : one stone two birds @alesj it may be horrible but once the code is written it's done

vietj commented 8 years ago

I won't change it myself :), it's an issue for improvement.

vietj commented 8 years ago

I mean it's not that I don't want to do it, it's just an issue to record what needs to be done.

vietj commented 8 years ago

the main problem is that the ceylon-maven-plugin cannot resolve maven module because the aether api is too old and conflicting with the recent maven aether apis creating classloading prb