ceylon / ceylon-spec

DEPRECATED
Apache License 2.0
108 stars 34 forks source link

recent commits break ceylon.ast #1418

Closed jvasileff closed 9 years ago

jvasileff commented 9 years ago

The combination of the following commits:

ceylon-model 4686519 fix method name! 9e3e479 cleanup

ceylon-spec 9b88cea minor

breaks ceylon.ast:

compile-source-jvm:
[ceylon-compile] /Users/jvasileff/Dropbox/Repos/ceylon/ceylon.ast/source/ceylon/ast/core/Editor.ceylon:341: error: argument must be assignable to parameter 'components' of 'copy' in 'FullPackageName': 'LIdentifier[]' is not assignable to '[PackageName+]' ('[LIdentifier+]')
[ceylon-compile]             => that.copy([for (component in that.components) transformLIdentifier(component)]);
[ceylon-compile]                          ^
[ceylon-compile] /Users/jvasileff/Dropbox/Repos/ceylon/ceylon.ast/source/ceylon/ast/core/Editor.ceylon:441: error: argument must be assignable to parameter 'children' of 'copy' in 'IntersectionType': 'PrimaryType[]' is not assignable to '[PrimaryType+]'
[ceylon-compile]             => that.copy([for (child in that.children) transformPrimaryType(child)]);
[ceylon-compile]                          ^
[ceylon-compile] /Users/jvasileff/Dropbox/Repos/ceylon/ceylon.ast/source/ceylon/ast/core/Editor.ceylon:920: error: argument must be assignable to parameter 'children' of 'copy' in 'UnionType': '<IntersectionType|PrimaryType>[]' is not assignable to '[IntersectionType|PrimaryType+]'
[ceylon-compile]         return that.copy([for (child in that.children) transformIntersectionTypeOrPrimaryType(child)]);
[ceylon-compile]                          ^
[ceylon-compile] /Users/jvasileff/Dropbox/Repos/ceylon/ceylon.ast/source/ceylon/ast/samples/turingMachine/create.ceylon:281: error: argument must be assignable to parameter 'children' of 'UnionType': 'BaseType[]' is not assignable to '[IntersectionType|PrimaryType+]'
[ceylon-compile]                         then UnionType([for (state in acceptingStates_seq) baseType(stateTypeName(state))])
[ceylon-compile]                                        ^
[ceylon-compile] 4 errors
[ceylon-compile] Note: Created module ceylon.ast.core/1.1.1
[ceylon-compile] Note: Created module ceylon.ast.redhat/1.1.1
[ceylon-compile] Note: Created module ceylon.ast.samples/1.1.1
[ceylon-compile] Note: Created module ceylon.ast.create/1.1.1
[ceylon-compile] ceylon compile: There were 4 errors

From the errors, it looks like Sequentials formed from Sequences are no longer recognized as nonempty.

gavinking commented 9 years ago

Does @e8877ee572380d78a24f22e65ad02a907184d3c3 fix it?

jvasileff commented 9 years ago

Yep. Thanks!