Should we have several classes for value setter definitions?

ceylon / ceylon.ast

Apache License 2.0

18 stars 3 forks source link

Should we have several classes for value setter definitions? #55

Open lucaswerkmeister opened 10 years ago

lucaswerkmeister commented 10 years ago

We could have either

ValueSetterDefinition(LIdentifier name, Block|LazySpecifier definition, Annotations annotations)

or something like

AnyValueSetterDefinition(Block|LazySpecifier definition) (abstract)
- ValueSetterDefinition(LIdentifier name, Block definition, Annotations annotations)
- ValueSetterShortcutDefinition(LIdentifier name, LazySpecifier definition, Annotations annotations)

Which one is better?

lucaswerkmeister commented 10 years ago

I’ll implement the first variant for now, since I’m not sure if the added complexity of the second one is worth it. Leaving the issue open though.

lucaswerkmeister commented 10 years ago

We’ll keep the first variant for now. ceylon.ast can, by its nature, break compatibility between language releases anyway, so I’m not too concerned about potentially making this change after the initial release.

gavinking commented 10 years ago

I think the first variation is much better. In general, => ... vs `{ ... } is a mere syntactic distinction with no real semantic significance.