Update expression type hierarchy?

lucaswerkmeister commented 9 years ago

In ceylon/ceylon-spec@9cd833c589d868315d8c53f1df43cfcabe971360 (and previously ceylon/ceylon-spec@74dbfa1e6ae26e4eb922564e35465fcf0b296b4c), @gavinking shuffled some BNF rules around. In ceylon.ast terms, that means:

new abstract LiteralExpression of Literal | StringTemplate
new abstract DelimitedExpression of GroupedExpression | Enumeration | ObjectExpression
new abstract Enumeration of Iterable | Tuple | DynamicValue
new abstract MetaExpression of Meta | Dec
rename of ElementOrSubrangeExpression to IndexedExpression
BaseExpression extending Atom instead of Primary

I like these changes, but they’re nevertheless potentially quite breaking. Should we do them in ceylon.ast? Gavin WDYT?

gavinking commented 9 years ago

The only reason I added DelimitedExpression, LiteralExpression and MetaExpression was because I otherwise couldn't fit the Atom rule on one line. I don't see how they're useful. Same goes for Enumeration, probably. But yes, the refactoring between Atom and Primary is necessary to be correct, I think.

lucaswerkmeister commented 8 years ago

Closing, won’t do this.

ceylon / ceylon.ast

Update expression type hierarchy? #74