search

cezanne / usbip-win

USB/IP for Windows
GNU General Public License v3.0
1.91k stars 344 forks source link

driver: use ExAllocatePool2 #340

Open makinbacon21 opened 1 year ago

makinbacon21 commented 1 year ago

ExAllocatePoolWithTag is deprecated as of Win10 20.04 This adds compat for newer WDK releases I'll admit this was a oneshot PR, so def needs review, but this should mostly be a drop-in replacement (https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/updating-deprecated-exallocatepool-calls)

vadimgrn commented 1 year ago

I recommend turning your attention to https://github.com/vadimgrn/usbip-win2 because this repository is de facto abandoned.

makinbacon21 commented 1 year ago

there is no arm64 support in your fork, and the dev branch here does not seem abandoned, just the dev makes bulk commits he force pushes

vadimgrn commented 1 year ago

Let's see, the last commit was Jan 16 2022. It's better to add required architecture than to do work that was already done.

makinbacon21 commented 1 year ago

no need to be rude--if you'd like to add arm64 support to your fork, be my guest. for now, i will use what is available, which is this. grep-ing and replacing one method with another requires far less effort compared to adding full arm64 support to another fork.

makinbacon21 commented 1 year ago

i do not care, i did 5 mins of work to help myself, and dropped this in here as i always do with oss projects, so the maintainer can see if they would like to. i don't care if it's upstreamed or not, but there it is.