search

cezarsa / silver_bird

Extension to access your Twitter from the Google Chrome browser.
http://cezarsa.github.com/silver_bird/
MIT License
287 stars 87 forks source link

Added photo thumbnails to tweets with entities #424

Open rsvargas opened 10 years ago

rsvargas commented 10 years ago

Added an option to show a small preview of photos identified by the entities object. Kinda like Twitter's new interface.

kav2k commented 9 years ago

@rsvargas I'm making a fork of Silver Bird, since it is no longer maintained. Would you mind if I include your patch?

rsvargas commented 9 years ago

Of course I don't mind, feel free to add these. I'll be glad!

theDraco commented 9 years ago

@kav2k: Do you plan to make it public? What will the name be? Can you make the "mute" and "block" features work? Right now if you block or mute someone, their tweets still show up in Silverbird.

@rsvargas: How do I get this to work? I have copied all 10 files you changed into the 1.9.10.2 Silverbird folder, but when I'm done it says the extension is corrupted. I have done it 3 times now, what am I doing wrong? I'm trying to get images to display in the Silverbird window.

kav2k commented 9 years ago

@theDraco It's up at https://github.com/kav2k/silver_feather I changed the name to Silver Feather to avoid confusion. It's currently published to the Web Store but it unlisted (not searchable) until I straighten up more pressing problems. You can install it already as some important fixes are already in.

You can't just replace files of a packed extension, Chrome will block that. You need to download the whole thing and load it as unpacked in developer mode.

theDraco commented 9 years ago

@kav2k Great, I got it working. A couple questions. Is it possible to get the "mute" and "blocked" functions working in Silverbird? Right now if you mute someone their tweets still show up in Silverbird. The same if you block them.

And one more thing, is it possible to make the image previews full size? Right now if you hover over an image link the preview is very tiny, can I make it bigger?

kav2k commented 9 years ago

@theDraco I think I'm going to implement larger previews, but it's not high priority. Feel free to add bugs about that and mute/blocked on my issue tracker so I don't forget about it.

rsvargas commented 9 years ago

@theDraco I'll probably rewrite this as a pull request do @kav2k 's new fork in a few days. So is probably best to wait for that.

If you still want to get this before and you are having problems with the merge, you can try to checkout this branch from my fork: https://github.com/rsvargas/silver_bird/tree/photo-thumbnails

kav2k commented 9 years ago

@rsvargas I'm not that eager to merge this in right away; I haven't tested it yet and it's kind of a low priority compared to a lot of other issues. I'd still be happy if you make a pull request - just don't expect it to be merged very fast.