search

cezary / react-diff

Given two inputs, highlights the differences
http://cezary.github.io/react-diff/
124 stars 39 forks source link

Remove deprecations #12

Closed ngryman closed 6 years ago

ngryman commented 6 years ago

Hey,

As of React 0.15.5 PropTypes and React.createClass are deprecated and as of React 16 officially thrown away from the core.

This PR makes your library compatible again with any version of React >= 0.15.5.

ngryman commented 6 years ago

@cezary You're probably busy, but this PR should be a safe merge, and the review super quick. Do you think you could take a look this week? 🙏 Thanks!

export-mike commented 6 years ago

@cezary happy to contribute as a maintainer with @ngryman ?

fernfernfern commented 6 years ago

If this could get merged in that would be really amazing

For anyone who can't wait:

yarn add cezary/react-diff#12/head

export-mike commented 6 years ago

@fernfernfern this repo hasn't been updated in a long time! maybe we should just fork the repo and publish under a scope on npm? yarn add @fernfernfern/react-diff

fernfernfern commented 6 years ago

@export-mike I didn't even know you could do that. That sounds like a better approach. Thanks for the heads up

export-mike commented 6 years ago

yeah when you publish just add your npm username under the name in package.json "name": "@fernfernfern/react-diff"

then publish yarn publish --access public as scopes by default are private and cost money!! 💰

export-mike commented 6 years ago

@fernfernfern I shall look forward to installing yarn @fernfernfern/react-diff 👍

fernfernfern commented 6 years ago

already squared away @export-mike ! https://www.npmjs.com/package/@fernfernfern/react-diff thanks again for the tip. I was getting nauseous looking at a pull request referenced in my package file :nauseated_face:

export-mike commented 6 years ago

LEGEND! :D

On Wed, Dec 20, 2017 at 11:51 AM, Fern notifications@github.com wrote:

already squared away @export-mike https://github.com/export-mike ! https://www.npmjs.com/package/@fernfernfern/react-diff thanks again for the tip. I was getting nauseous looking at a pull request referenced in my package file 🤢

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cezary/react-diff/pull/12#issuecomment-352932036, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2Fn1T9YV81mYL69vc4vsnRbPPVUWnyks5tCFoSgaJpZM4QOfv4 .

export-mike commented 6 years ago

image 🎉

ngryman commented 6 years ago

Closing this as it's unlikely to be ever merged. Thanks guys for the workarounds!