cezary / react-progress

Simple youtube style progress bar for React
http://cezary.github.io/react-progress
153 stars 13 forks source link

Use uniform quote character and use React directly to avoid JSX #2

Closed cymen closed 9 years ago

cymen commented 9 years ago

I couldn't use this module with what appear to be the best practices in webpack land. I had two issues:

1) Use of ` as quote character instead of more common quote styles (' or ") breaks on UNIX/OS-X. 2) Using JSX in the file exported by package.json's main entry.

I fixed both of these issues in this PR and am now able to use this module in a webpack environment. The webpack environment avoids applying the transforms we are using (JSX, bable for es6) as the convention in the webpack community seems to be not to apply those to external modules.

Does this work for you?

cymen commented 9 years ago

Cleaning up in a nicer way.