Closed zpqrtbnk closed 5 years ago
Hi
Could you provide definitions of Thing1
and Thing2
classes?
Tried to do my homework, using the unit tests in the MappingGenerator project. Been able to narrow it down to
public class Thing1
{
public string Value { get; set; }
}
public class Thing2
{
public Thing2(string value)
{ }
public string Value { get; set; }
}
The non-empty ctor is killing it. Which... kinda makes sense I assume?
I guess this could be related to the new feature #64 I will take a look at this on the next weekend. Thanks for due diligence.
Cool. No rush, enjoy your weekend ;-)
I was't able to reproduce this issue using your example. Here's the proof
Can you create a fork with UT that is reproducing the problem?
Still no luck with reproducing, but probably I've found the culprit. Here's version with the fix https://ci.appveyor.com/api/buildjobs/24v6iq24h1bxu8rx/artifacts/MappingGenerator%2FMappingGenerator%2FMappingGenerator.Vsix%2Fbin%2FRelease%2FMappingGenerator.vsix
@zpqrtbnk would you mind to install it and verify if everything is working as expected?
Hi @zpqrtbnk, did you have an occasion to test this new feature?
Arh - got side tracked on other stuff, will try soon as I can
I was experiencing the same issue. Downloaded the above version. Now, all is well. Thanks!
Thanks @brrbtr for testing.
An official version with this fix was released Please install version of the official channel https://marketplace.visualstudio.com/items?itemName=54748ff9-45fc-43c2-8ec5-cf7912bc3b84.mappinggenerator
I create this code:
Where
Thing1
andThing2
have some properties in common, and other, non-common properties. Oh and they might also have properties matching by name but not by type. And maybeThing1
has only parameter-less constructors.Gettings this exception soon as I hit the generate menu:
Is it... that I am doing something that I should not do, or is it some kind of anomaly?