search

cezarywojcik / CWPopup

CWPopup category to present popup view controllers
MIT License
289 stars 62 forks source link

Landscape iPad #20

Closed komocode closed 9 years ago

komocode commented 9 years ago

Does not work properly in landscape view for iPad.

screen shot 2014-10-15 at 9 44 16 am

cezarywojcik commented 9 years ago

This is probably due to the fact that iOS 8 changed/corrected the way screen width and screen height are returned (prior to iOS 8, screen height was always the same value regardless of orientation - in iOS 8, screen height changes depending on the orientation). I don't quite have time to fix this right now, but feel free to shoot me a PR.

tbowers commented 9 years ago

I believe this has been fixed by this pending pull request https://github.com/cezarywojcik/CWPopup/pull/18.

tbowers commented 9 years ago

Actually it seems like master is already good to go here. I'll cancel the PR. Thanks.