search

cezarywojcik / CWPopup

CWPopup category to present popup view controllers
MIT License
289 stars 62 forks source link

Adds travis support + base tests for the project #27

Closed Goles closed 9 years ago

Goles commented 9 years ago

Hey @cezarywojcik ,

I added travis support for your project + some tests. This was my project for the Cocoa Pods Test Jam SF.

The only thing that you have to do to get this to work is to actually create a travis account and enable travis for the master branch of your project (I can't since I don't really have write access to the project).

After you enable travis, also remember to modify your travis build status badge URL, you should point it directly to your repo in README.md 

[![Build Status](https://travis-ci.org/cezarywojcik/CWPopup.svg?branch=master)](https://travis-ci.org/cezarywojcik/CWPopup)

PS: I also want to add more test coverage for some situations, but I see that you're supporting iOS 4.3+. I was wondering if it's possible for you to support 6.0+?

cezarywojcik commented 9 years ago

I kept the support at iOS 4.3+ because I didn't really have a reason not to. I'm not opposed to upping 6.0+ or even 7.0+.

Honestly, though, I've been considering rewriting this library from scratch in Swift, though I'm not sure whether I'd make that a 3.0 update here or just a new repo.

Goles commented 9 years ago

I think there's enough people already using this library on their projects (data from Cocoa Pods stats). I was going to rewrite it in Swift I would definitely create a new repo and build a Swift and iOS 8.0+ version :+1:

I'll probably send you another PR with a couple extra tests.

Cheers!