search

cezheng / Fuzi

A fast & lightweight XML & HTML parser in Swift with XPath & CSS support
MIT License
1.08k stars 161 forks source link

Remove wrapping libxml2 modulemap for Xcode 9.3 #83

Closed banjun closed 6 years ago

banjun commented 6 years ago

Fixes #77. Although the issue has been referenced by several PRs, this PR patches in another way, that does remove libxml2/module.modulemap from Fuzi.

The modulemap is no longer needed because Xcode 9.3 has the modulemap in its SDK. (It's not included in Xcode 9.2 and before.) Accordingly this also removes SWIFT_INCLUDE_PATHS a.k.a. Import Paths as it no longer exists, and adds -lxml2 to the project as README says at the Install Manually section.

SuperY commented 6 years ago

Need fix tvOS build params in travis file.

SuperY commented 6 years ago

This is my way:

Change ".swift-version" file --> 4.1

Update ".travis.yml" osx_image: xcode9.3beta - DESTINATION="platform=tvOS Simulator,name=Apple TV 4K" SDK="appletvsimulator" ACTION="test"

banjun commented 6 years ago

@SuperY Thank you pointing out!

cezheng commented 6 years ago

This is purely awesome!

Extra thanks for updating the Japanese/Chinese README :smile:

skathiresan commented 6 years ago

@banjun @cezheng Shouldn't we also need to update the pod version?

drosenstark commented 6 years ago

Will this new version work in Xcode 9.2 without the libxml2/module.modulemap? I've got a complex situation with this dependency and need to tease out what is what. Thanks!

banjun commented 6 years ago

@drosenstark No. It completely depends on Xcode 9.3. You should use Fuzi 2.0.1 when you build with Xcode 9.2.

cezheng commented 6 years ago

Correct. The latest version only supports latest Xcode. Use old versions of Fuzi for old versions Xcode.