search

ceztko / SolutionConfigurationName

A Visual Studio 2010-2017 extension that sets SolutionConfiguration and SolutionPlatform build macros
https://marketplace.visualstudio.com/items?itemName=ceztko.SolutionConfigurationName
Other
12 stars 12 forks source link

Add mandatory dependency on Visual Studio Core Editor #4

Closed trueqbit closed 7 years ago

trueqbit commented 7 years ago

Carlos Quintero states in his blogpost http://www.visualstudioextensibility.com/2017/01/10/its-time-to-change-the-vsix-manifest-of-your-extension-to-v3-for-visual-studio-2017-compatibility/ that an extension should depend on Visual Studio Core Editor at the very least.

ceztko commented 7 years ago

Yes, I had this issue initially, because the Prerequisites section was missing. I solved by just adding a dependency on .NET 4.6.1 SDK. It may be not a good choice after all and yours may be better. So far, did you have practical problem with the current Manifest?

trueqbit commented 7 years ago

I was only wondering why there's a dependency on .NET 4.6.1 SDK, but otherwise the extension worked well with the current manifest.

trueqbit commented 7 years ago

Er... One thing I noticed is that, when double-clicking on the extension in order to install it, it needs a long time initializing - it seems to be searching for something until the dialog with the "install" button for the found VS versions is presented. Not sure though whether this is related to dependeny on the .NET SDK.

ceztko commented 7 years ago

According to this[1] document, the Visual Studio Core Editor has components like TextBuffer, TextView, etc. that are facilities used to enable graphical editing of the code. The extension could, at least in theory, run without a graphical editor. Instead, I will pick the dependency on MSBuild, which is the Microsoft build system I am leveraging to set the build macros, dropping at the same the dependency on .NET SDK which could be not installed on the target system. This, I think, should address your concern.

[1] https://msdn.microsoft.com/en-us/library/bb165971.aspx