search

cf-convention / cf-conventions

AsciiDoc Source
http://cfconventions.org/cf-conventions/cf-conventions
Creative Commons Zero v1.0 Universal
87 stars 46 forks source link

Minor update to PR template community file #491

Closed sadielbartholomew closed 11 months ago

sadielbartholomew commented 11 months ago

See issue #XXX for discussion of these changes. See https://github.com/cf-convention/cf-conventions/pull/489#issuecomment-1827828116 for the context behind the core update, which is to state to be explicit that there are two places where names should be updated in the cf-conventions.adoc document, preventing confusion in future that led to separate PRs being required to add names again.

Since this is an infrastructure tweak, the release checklist is not applicable so I have quoted it to effectively comment it out.

@larsbarring I have assigned you as reviewer since you are quite active on this repo of late, but feel free to re-assign should you wish. I don't think the change is controversial but will need someone to approve it regardless to confirm it's OK. Thanks.

Release checklist

  • [ ] Authors updated in cf-conventions.adoc?
  • [ ] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • [ ] history.adoc up to date?
  • [ ] Conformance document up-to-date?
  • [ ]

For maintainers

After the merge remember to delete the source branch. Tags are set at the conclusion of the annual meeting; until then, main always is a draft for the next version.

sadielbartholomew commented 11 months ago

Thanks for the prompt review, @larsbarring. Can I now merge this?

larsbarring commented 11 months ago

Yes, please do /Lars