cf-convention / cf-conventions

AsciiDoc Source
http://cfconventions.org/cf-conventions/cf-conventions
Creative Commons Zero v1.0 Universal
88 stars 46 forks source link

missing links in wiki page cited in Appendix F #537

Open KCANNIZZARO opened 2 months ago

KCANNIZZARO commented 2 months ago

ON THE PAGE ENTITLED Mapping from CF Grid Mapping Attributes to CRS WKT Elements THERE IS A LINK TO A WEBSITE CALLED REMOTESENSING.ORG, BUT WHEN YOU CLICK ON IT, NO SITE HAS BEEN PUBLISHED TO THAT DOMAIN

JonathanGregory commented 2 months ago

@KCANNIZZARO, thanks for your help. Do you mean on the page https://cfconventions.org/wkt-proj-4.html, or some other page? Please could you say where in the page concerned you find this missing link, because I can't find it, and our regular link-checker program hasn't detected it.

larsbarring commented 2 months ago

In Table F.1 (in Appendix F) of the Conventions document there are several links to this wiki page, which was last edited in early 2017 and contains links to remotesensing.org (there are other stale links in this page).

JonathanGregory commented 2 months ago

Thanks, @larsbarring. I think https://cfconventions.org/wkt-proj-4.html, which is linked to the CF website, is an updated version of https://github.com/cf-convention/cf-conventions/wiki/Mapping-from-CF-Grid-Mapping-Attributes-to-CRS-WKT-Elements. The former doesn't have missing links, I believe, since the web link-checker would find them if it did. If that's right, we should update Appendix F.

larsbarring commented 2 months ago

Yes, I agree that Appendix F needs to be updated. We also have https://github.com/cf-convention/cf-conventions/issues/479 that preferably should be dealt with at the same time. And there are a couple of other improvements that are overdue. I have for a long time meant to do something about this, but it has not yet happened.

JonathanGregory commented 2 weeks ago

I have created https://github.com/cf-convention/cf-conventions/pull/563 to remedy this defect, by replacing the references to the wiki page with references to the updated Mapping from CF Grid Mapping Attributes to CRS WKT Elements, which doesn't contain the broken links.

Since this is a defect issue, the change will be accepted if no-one raises concerns within three weeks (27th Nov).

larsbarring commented 2 weeks ago

I added a couple of comments in the PR regarding files missing in the referred wiki page.

JonathanGregory commented 1 week ago

Thanks, @larsbarring. The file ellipsoid.csv and the other two csv files are attachments to the GitHub wiki page. They were intended to be linked at the bottom of the CF-WKT page, which itself is linked from Appendix F, but they appear there as now-defunct URLs to the old trac wiki instead. Whoops.

I have therefore prepared a website PR to correct the links in my modified version of the CF-WKT webpage, so that they point to the versions in the GitHub wiki. These links now appear after Table 2 in the webpage, which is where they're relevant. Noticing that the webpage was quite out-of-date, I've brought Tables 1 and 2 up to date and made them compatible with GitHub markdown so their contents are displayed properly.

I have modified the conventions PR #563 to say more precisely where the information can be found e.g. for the reference_ellipsoid_name, "Valid names are given in ellipsoid.csv, following Table 2 in CF-WKT."

I hope this is all OK.

larsbarring commented 3 days ago

Thanks Jonathan @JonathanGregory !

This looks all good!