cf-convention / vocabularies

Issues and source files for CF controlled vocabularies
3 stars 1 forks source link

Standard names: Typo/Error for the name moles_of_particulate_inorganic_carbon_per_unit_mass_of_sea_water #126

Closed DocOtak closed 1 year ago

DocOtak commented 1 year ago

While mapping the new names from cf-convention/vocabularies#169 submitted by @fcarvalhopacheco on behalf of HOT/CCHDO (myself included) to existing vocabularies already in use in GO-SHIP/WOCE. I noticed we used the *_of_sea_water form. I did some looking and this appear to be an error because this is not a property of the water itself and I think we should have used the *_in_sea_water form.

As such, I think this needs correcting to moles_of_particulate_inorganic_carbon_per_unit_mass_in_sea_water and add the erroneous name as an alias.

JonathanGregory commented 1 year ago

Dear Andrew @DocOtak

Thanks for raising this point. I see there are currently 12 names of the form moles_of_X_per_unit_mass_in_sea_water and one with of (the one you mention). I think either form could be correct, because it's referring to a unit mass of sea water. But we ought to be consistent, and if both are OK it's easier to make the change you suggest. Also that will lead to fewer mistakes because all the other kinds of concentration names (without per_unit_mass) have in. So I agree with you.

Best wishes

Jonathan

DocOtak commented 1 year ago

Hi @JonathanGregory I think this also is inline with the naming guidelines for mediums, but am not quite sure.

fcarvalhopacheco commented 1 year ago

@roy-lowry

roy-lowry commented 1 year ago

@fcarvalhopacheco Thanks. I totally agree with this correction.

JonathanGregory commented 1 year ago

I've marked this as accepted because it's a defect and no concerns have been raised for three weeks. Thanks for the proposal, @fcarvalhopacheco.

feggleton commented 1 year ago

Thanks all, have added this to the next update on Monday.

japamment commented 1 year ago

I am closing this ticket as the proposed change was added in V81 of the standard name table.