search

cf-convention / vocabularies

Issues and source files for CF controlled vocabularies
3 stars 1 forks source link

Standard names: drainage_amount_through_base_of_soil_model duplicated in final XML file at website #56

Open geofranzi opened 10 months ago

geofranzi commented 10 months ago

The current version of the XML contains a duplicate entry id: "drainage_amount_through_base_of_soil_model"

https://github.com/cf-convention/cf-convention.github.io/blob/main/Data/cf-standard-names/current/src/cf-standard-name-table.xml

I do not know where it is generated, but I assume the issue belongs more to this repo.

image

github-actions[bot] commented 10 months ago

Thank you for your proposal. These terms will be added to the cfeditor (http://cfeditor.ceda.ac.uk/proposals/1) shortly. Your proposal will then be reviewed and commented on by the community and Standard Names moderator.

efisher008 commented 10 months ago

Dear @geofranzi,

Thank you for bringing this up. Looking at the current version of the table it appears that this standard name was proposed by issue cf-convention/vocabularies#146, but one of the two versions in the XML file is a term change from vertical_drainage_amount_in_soil (which has been retained as an alias) and the other is a standalone name with no alias. I've been trying to track which table versions these were introduced in and it looks like this:

image

The description for the standalone name drainage_amount_through_base_of_soil_model is slightly different to the aliased version of the name as you can see in the screenshot of the XML file above, and is in my opinion more descriptive. I would therefore suggest that the description for the aliased name is perhaps updated with this text, and the standalone name is then removed from the table.

It looks as though @feggleton handled the original issue so maybe she might have some input here?

Best regards, Ellie

feggleton commented 9 months ago

Thanks for pointing this out, this is in error. Thanks @efisher008 for doing some digging. Basically, the name 'drainage_amount_through_base_of_soil_model' should be in the table as a standalone name with no alias, with the description:

“Drainage” is the process of removal of excess water from soil by gravitational flow. "Amount" means mass per unit area. The vertical drainage amount in soil is the amount of water that drains through the bottom of a soil column extending from the surface to a specified depth.

vertical_drainage_amount_in_soil should never have been in the table.

We will need to depreciate the aliased version and just keep the standalone one with the right description. @efisher008 @japamment let's work through this in the cfeditor on Monday.

larsbarring commented 7 months ago

It is great that this will be taken care of in the upcoming version of the standard name table!

As you might have seen I am also looking through all already published versions, and as @efisher008 notes the problem discussed here goes back a couple of versions. Most of them should be possible to correct also in the already published version through the tools I have. But I am not sure that I fully understand exactly what needs to be done in each version. Thus it would be great if you could provide some specific guidance, preferably in a comment over in that repo issue.

Many thanks, Lars

feggleton commented 3 months ago

As far as I'm aware this has now been resolved. Are we happy this can now be closed? There is no longer a duplicate in the xml and everything is as it should be.