cf-convention / vocabularies

Issues and source files for CF controlled vocabularies
3 stars 1 forks source link

ocean_volume vs. sea_water_volume #61

Closed taylor13 closed 1 week ago

taylor13 commented 2 years ago

What is the difference between "ocean_volume" and "sea_water_volume". In the standard names listing, the note for sea_water_volume says "The quantity with standard name "sea_water_volume" is the total volume of liquid seawater in the global oceans, including enclosed seas." There is no information provided regarding "ocean_volume". Should these two names be declared aliases for the same thing?

JonathanGregory commented 2 years ago

I agree that òcean_volume should be an alias of sea_water_volume and therefore ocean_volume_fraction should be renamed (made an alias) of sea_water_volume_fraction. I think the latter also makes sense because sea water is the name of the medium from which the ocean is composed.

github-actions[bot] commented 1 year ago

This issue has had no activity in the last 30 days. This is a reminder to please comment on standard name requests to assist with agreement and acceptance. Standard name moderators are also reminded to review @feggleton @japamment

efisher008 commented 3 months ago

Hi @taylor13 @JonathanGregory,

I agree with the above discussion and have made the following changes in the editor (although they are currently labelled as "under discussion"):

Is this what you intended? Would it also be needed to alter the description of both names to include the definition of the phrase sea_water i.e. add "Sea water refers to liquid seawater in the global oceans, including enclosed seas."? This could then be added to the CF phrasebank. The wording of this can be changed if necessary.

Another question: should I now remove the "old" ocean_volume name from the table? I don't believe this should cause any issues as it is now an alias of sea_water_volume, and the old name doesn't have a description so there is nothing to transfer.

Best wishes, Ellie

JonathanGregory commented 3 months ago

Dear Ellie

Yes, that's what was meant. It would certainly be an improvement to add the definition of sea_water to the description of these names, thanks. I don't think we ever delete names from the table, do we. That's the reason for having aliases. There may be existing archived datasets which use the standard name ocean_volume, so we have to keep it in the table, as an alias of sea_water_volume, where its definition will go. Have I misunderstood?

Best wishes

Jonathan

efisher008 commented 3 months ago

Dear Jonathan,

Apologies, I think I misunderstood how the name would be transformed when aliased. What I meant is that ocean_volume should no longer have its own entry in the table, rather it should be attached as an alias to the published name sea_water_volume. The way that the CF editor works currently is that a name is automatically aliased when a term change is proposed (accepted) from the previously published version. It is also possible to manually add an alias in the system without proposing a term change, which is what I had done. I thought that there would therefore be a standalone entry remaining for ocean_volume which would need to be dealt with, but it actually seems as though this has been taken care of when the alias was created, so there is no need to remove/'delete' anything (which as you said is not done for the standard name table).

Best wishes, Ellie

efisher008 commented 3 months ago

Both changes have now been accepted as the issue previously reached a consensus and there have been no new comments to the contrary. Thank you @taylor13 @JonathanGregory for your comments.

JonathanGregory commented 3 months ago

Thanks for your help, Ellie, and your explanation of how the editor manages aliases.

taylor13 commented 3 months ago

Yes, thank you for cleaning this all up.