search

cf73 / Race2

0 stars 6 forks source link

clicking 'view lesson plan' inside a lesson plan when toggled open no longer launches the lesson plan overlay as it did before #49

Open cf73 opened 6 years ago

cf73 commented 6 years ago

please restore this functionality

cf73 commented 6 years ago

change from showing overlay to just loading a new page with the lesson plan fields on it. I'll hook up the queries, you just need to do the routing.

eugenehp commented 6 years ago

ok, please link a new branch for this, and I'll take it over from there @cf73

cf73 commented 6 years ago

@eugenehp this is incomplete/buggy: I see you entered all the queries in the lesson plan fragment, but then never hooked them up in the component, so most of the fields do not show up. also, there is no conditional logic, where the design file specifies that fields and their titles should only show up if that content exists.

finally, the word 'MATERIALS' shows up always, even when there are no materials.

this should be completed under the already-paid budget for this scope, since it was before we switched to hourly. I can't move forward with styling until this is done, so after homepage please prioritize.

cf73 commented 6 years ago

update: agreed to pay for as this includes new responsive design etc. moving to fixes scope

cf73 commented 6 years ago

@eugenehp please get on this and finish it ASAP.