search

cfallin / waffle

Apache License 2.0
56 stars 5 forks source link

Validate operator return types #2

Open bjorn3 opened 7 months ago

bjorn3 commented 7 months ago

Currently passing no return types for i32const and i32add passes validation, but results in a compilation panic.

bjorn3 commented 7 months ago

Looks like argument count isn't validated either. At least for i32eq.

bjorn3 commented 7 months ago

Nor is the alignment of memory operations being valid validated.

bjorn3 commented 7 months ago

Another thing missing is checking for mismatches between block params and BlockTarget.

cfallin commented 6 months ago

These are all things that should be validated, indeed!

waffle was codeveloped with weval and so has not had a separate pass of robustification or API cleanup in general -- this is one example, where the validator was built to help debugging efforts but is not complete. I'm happy to review PRs that add any/all of the above!