search

cfangmeier / tuijam

A fancy TUI client for Google Play Music
MIT License
129 stars 9 forks source link

Add Last.fm support #32

Closed t1meshift closed 5 years ago

t1meshift commented 5 years ago

'Playing now' and scrobbling are supported now. Fixes #28 :octocat:

cfangmeier commented 5 years ago

Thanks for implementing this. I just tested it out and it works great for me! I have two (hopefully small) requests:

  1. In lastfm_conf(), can you attempt to open that url in the browser automatically, and if that fails, fall back to what's currently done?
  2. Also in lastfm_conf(), can you put the key in the user's config file automatically, instead of having them edit it themselves.
t1meshift commented 5 years ago

Done. I've also implemented session key encryption as it has eternal lifetime (unless you revoke it in settings) and gives write access to an account. The code is not quite clean for now, but it works if you are not intended to break the app :)