Upgrade Opeka module to Drupal 8

[benjamin-dk]

The Opeka module and submodules should be upgraded.

The priorities are as follows

1. Upgrade main module, making sure the following features work
   • Migrate stored data of main module from D7
   • Admin pages - forms and database getting and setting values
   • Various values to be added as JS variables (opeka_add_assets)
   • Widget pages should work
   • Statistics functionality
   • Backbone.js integration
2. Opeka Screening submodule
3. Opeka Opening Hours
4. Opeka Invites
5. Opeka Features

An upgraded version of the Bootstrap theme can be found here (a subtheme to Bootstrap 3): https://github.com/cfdp/cura-chat-theme/tree/release/v2.0

[stefanospetrakis]

• First commits are available here https://github.com/cfdp/opeka/commits/feature/drupal8_refactor
• At the moment the module is not yet functional, the main blocker is the https://github.com/benjamin-dk/node-drupal dependency that needs to be refactored for Drupal 8
• The backbone/underscore library versions provided by Drupal core need to be checked against the current code base and may possibly lead to refactoring that code base. A first check (switching to using the core/* libraries) produced errors. As an alternative, the library versions that the Drupal 7 version of the module "carries" with it can be used.

What was done:

• Most D7 variables have been refactored into the module's D8 configuration
• The html+backbone templates for the two chat modes (fronted, backend) are now twig templates
• CSS+JS files are now defined as D8 libraries; drupal_add_js logic has been refactored as libraries (static) except for the dnode connection URL (/connect.js) which has been implemented as a dynamic library (hook_library_info_build)
• Frontend (anonymous) client interface can connect to a running dnode server
• All permissions (hook_permissions) were ported to the opeka.permissions.yml
• Some few routes (hook_menu) were ported to the opeka.routing.yml

[stefanospetrakis]

The Drupal 8 version of the node-drupal code is available here https://github.com/stefanospetrakis/node-drupal/tree/drupal8 Once reviewed, this could be used in the package.json:

https://github.com/cfdp/opeka/blob/feature/drupal8_refactor/nodejs/package.json#L25

[stefanospetrakis]

Moved current work on this to a branch of master, in order to 'link' to the latest state of work in D7. The latest commit "21a504ba8bd5aa8ab009ae31229acad9758913af" delivers:

• A functional D8 port that delivers configuration settings for the opeka system and backend management via Forms (sth like http://demod8.test/admin/config/services/opeka).
• The node_js component is now linked (package.json) to the work done for node-drupal (see previous comment).

[benjamin-dk]

Hi @stefanospetrakis it seems we have an issue with the authentication of some user roles / permissions.

When logging in as user 1 I get the expected permissions, but when creating e.g. a counselor role and granting the permission administer opeka chat(or even all opeka-related permissions) to a user, this user does not have access to the counselor methods.

I noticed that Opeka.clientData has two properties, admin and isAdmin being true and false. The issue lies here probably.

Server-side the user.authenticate process goes haywire in the drupal.user.access callbacks - they end up sending 1024 callbacks to front end.

Investigation continues...

[gvd1]

The problem stems from the node-drupal module - I made a PR here https://github.com/stefanospetrakis/node-drupal/pull/1 it should fix the permissions issue.

We still have a problem with too many callbacks.

[stefanospetrakis]

@gvd1 I am investigating this too, will look at the related PR soon.

[stefanospetrakis]

@gvd1 The problem with the permissions of (non-admin) users has been resolved, could you confirm the fix works for you?