search

cfe-lab / Kive

Archival and automation of bioinformatic pipelines and data
https://cfe-lab.github.io/Kive
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Remove choose_inputs.css from the project #578

Open rhliang opened 8 years ago

rhliang commented 8 years ago

James has been using Sass to compile down into the appropriate CSS. If we can get everyone on board with this change and have the users perform the necessary compilation, then we can lose choose_inputs.css.

donkirkby commented 8 years ago

Is this a grunt task like the embedded image data? If so, it sounds reasonable for developers to do as part of project set up.

jamesnakagawa commented 8 years ago

It could be made into a grunt task, yes. The question is, should the compiled .css files be included in the repository, or should compiling them be part of the install process?

donkirkby commented 8 years ago

It's a generated resource, so technically it shouldn't be in the repository. Same thing with the embedded icons. However, it is slightly more convenient for developers to not need to run grunt every time they pull. If having these things in the repository causes more work for you or causes people to get the wrong version of things, then we should take them out of the repository.

jamesnakagawa commented 8 years ago

More work for me: Not really, I need to compile to see what I’m doing anyway. Causes people to get wrong version: Not this either.

The only danger is that a developer will not see the .sass, edit the .css directly, and then have it be overwritten when the .sass is compiled again by another dev. But that’s our problem, so if we accept the risk of peril then I think we can keep it in the repo.

Just a note, it’s also possible to compile sass with python (i.e. manage.py).

On Jul 22, 2016, at 3:57 PM, Don Kirkby notifications@github.com wrote:

It's a generated resource, so technically it shouldn't be in the repository. Same thing with the embedded icons. However, it is slightly more convenient for developers to not need to run grunt every time they pull. If having these things in the repository causes more work for you or causes people to get the wrong version of things, then we should take them out of the repository.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cfe-lab/Kive/issues/578#issuecomment-234676609, or mute the thread https://github.com/notifications/unsubscribe-auth/AF172aWoqkPEpLt2ACMqLD8zM4gM76ANks5qYUrLgaJpZM4JRGVt.

donkirkby commented 8 years ago

Compiling sass and the embedded icons with Python intrigues me, @jamesnakagawa. It would be nice if we could run it as a management command when deploying with Apache and just run it automatically when starting up the development server. We could probably write a management command and then call it from some server startup hook. Let's choose a priority for this at the next meeting.

jamesnakagawa commented 7 years ago

There's something funky going on with our package.json regarding Sass, but I think it's just the matter of finding the right node package. I may take a look at this soon.