search

cfelton / rhea

A collection of MyHDL cores and tools for complex digital circuit design
MIT License
84 stars 33 forks source link

Addition of the Altera DE1 SOC board definition and basic examples. #26

Closed Godtec closed 8 years ago

Godtec commented 8 years ago

Attempt to create a Pull request across branches. So From my master branch from my fork, to your de1_soc branch. Hope it works!

This is the changes for the LT24LCD code for the de1_soc!! UNTESTED!!

Once this is accepted and completed, I will pull the changes for the VGA code.

Thanks! MikeK

cfelton commented 8 years ago

@Godtec, for this PR I won't bother trying to move it to a branch. For the most part it looks good, I can merge the PR and clean-up the couple minor things (extra files etc.).

Godtec commented 8 years ago

OK Great! Please do.

I don't know what happened with the last failed file? I will check that not to include that file in the future. But what I have been doing was pulling your repo, copying/editing the files that is required then testing it with a python compile to create the verilog code. So I might have missed this file after it complied.

I am working on the VGA port next. I am pretty much done, it did work as you said in the last pull request. The only issue on my end was that the one monitor did not like the image generated. I connected it to another monitor and it seemed to work. The only issue with your suggestion of removing the counter reset in your last comment in the pull request is that the horizontal sync signals continue on during the vertical blanking period.

After the VGA, I want to get the ADC to work. I have been looking at the code more closely, So I may have a few questions for you if that ok. especially the difference between the two ADC devices.

Thanks. MikeK

cfelton commented 8 years ago

@Godtec after a closer look, this PR is not achieving what you want:

Godtec/rhea/master --> cfelton/rhea/de1_soc

Also, I don't see where your changes are? The last three commits in this PR are from me (when you merged the cfelton/rhea/de1_soc branch). But it is all confusing