master PR - Githubissues

cfengine / cf-bottom

__init__

MIT License

3 stars 12 forks source link

master PR #12

Closed Lex-2008 closed 6 years ago

Lex-2008 commented 6 years ago

Code cleanup needed, don't review this PR yet.

long functions should be rewritten into classes
command-line options should be provided to switch between "github comments" and "slack messages" modes
also maybe we should tolerate lack of some secrets

Lex-2008 commented 6 years ago

@cf-bottom and @olehermanse: can you please confirm if you indeed think that having many separate functions like in class UpdateChecker() here is indeed more readable then one big 100-lines function like create_pr_magic() here

olehermanse commented 6 years ago

@Lex-2008 Smaller functions, classes (and even commits) are better, yes :)

olehermanse commented 6 years ago

@Lex-2008 Try to make a cleaner commit history with smaller changes at a time. Ping me when you want me to review.

cf-bottom commented 6 years ago

@Lex-2008 : I'm sorry, I cannot do that. @olehermanse please help.