cfengine / cf-bottom

__init__
MIT License
3 stars 12 forks source link

config.json and secrets.json #14

Closed olehermanse closed 6 years ago

olehermanse commented 6 years ago

We need to separate out a lot of parameters for @oleorhagen to run the bot. This is a proposal for the file:

config.json:

{
  "bots": [
    {
      "username": "cf-bottom",
      "secrets": "cfengine-secrets.json",
      "trust": ["olehermanse", "vpodzime", "craigcomstock"],
      "reviewers": ["olehermanse", "vpodzime"],
      "jenkins": "https://ci.cfengine.com/",
      "orgs": ["cfengine"],
      "repos": {
        "cf-bottom/self": ["olehermanse", "vpodzime"],
        "cfengine/core": ["olehermanse", "vpodzime", "craigcomstock"],
        "cfengine/enterprise": ["olehermanse", "vpodzime", "craigcomstock"],
        "cfengine/nova": ["olehermanse", "vpodzime", "craigcomstock"]
      }
    },
    {
      "username": "mender-bottom",
      "secrets": "mender-secrets.json",
      "trust": ["oleorhagen", "kacf"],
      "reviewers": ["oleorhagen", "kacf"],
      "jenkins": "https://mender-jenkins.mender.io/",
      "orgs": ["mendersoftware"],
      "repos": {
        "mendersoftware/mender": ["kacf", "oleorhagen", "pasinskim"]
      }
    }
  ]
}

secrets.json:

{
  "GITHUB_TOKEN": "1234abcdef",
  "GITHUB_USER": "cf-bottom",
  "JENKINS_USER": "a111111",
  "JENKINS_TOKEN": "1234abcdef",
  "JENKINS_CRUMB": "1234abcdef"
}

(If JENKINS_CRUMB is missing, it should still work, by not including it in header)

olehermanse commented 6 years ago

@vpodzime @oleorhagen, looks ok?

oleorhagen commented 6 years ago

Why does jenkins have to be a list? @olehermanse

olehermanse commented 6 years ago

@oleorhagen simple mistake.

oleorhagen commented 6 years ago

Same for orgs then?

olehermanse commented 6 years ago

No, I think orgs should be a list.

vpodzime commented 6 years ago

ACK