Adapted Tom to new deptables location and layout

Lex-2008 commented 3 years ago

They moved from README.md file in deps-packaging subdir to README.md in the repo root, and also titles include URLs now, too.

cf-bottom commented 3 years ago

Thank you for submitting a pull request! Maybe @olehermanse can review this?

Lex-2008 commented 3 years ago

ready 2b reviewed!

olehermanse commented 3 years ago

@Lex-2008 could you run this and paste the output here in a comment?

Lex-2008 commented 3 years ago

Text output:

[lex@flower2 cf-bottom]$ python -m tom -i -t cf-bottom -l info
<@cf-bottom> depstable: 3.12.x,3.15.x,master
fatal: remote upstream already exists.
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
Unpacking objects: 100% (13/13), 4.04 KiB | 229.00 KiB/s, done.
remote: Total 13 (delta 7), reused 7 (delta 7), pack-reused 5
From github.com:cfengine/buildscripts
 * branch            master     -> FETCH_HEAD
   d4d331c..5b55383  master     -> upstream/master
Switched to branch 'master'
Your branch is behind 'upstream/master' by 6 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
HEAD is now at 5b55383 Merge pull request #793 from olehermanse/mailmap
From github.com:cfengine/buildscripts
 * branch            3.12.x     -> FETCH_HEAD
Switched to branch '3.12.x'
Your branch is up to date with 'upstream/3.12.x'.
HEAD is now at 8331bcc Merge pull request #784 from Lex-2008/ENT-5363-suse15-3.12.x
Already up to date.
From github.com:cfengine/buildscripts
 * branch            3.15.x     -> FETCH_HEAD
Switched to branch '3.15.x'
Your branch is up to date with 'upstream/3.15.x'.
HEAD is now at 7f335cf Merge pull request #783 from Lex-2008/ENT-5363-suse15-3.15.x
Already up to date.
From github.com:cfengine/buildscripts
 * branch            master     -> FETCH_HEAD
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
HEAD is now at 5b55383 Merge pull request #793 from olehermanse/mailmap
Already up to date.
From github.com:cfengine/buildscripts
 * branch            master     -> FETCH_HEAD
Already on 'master'
Your branch is up to date with 'upstream/master'.
HEAD is now at 5b55383 Merge pull request #793 from olehermanse/mailmap
[WARNING] didn't find dep in line [| lcov             | 1.14   | 1.14   | 1.14   |]
[WARNING] didn't find dep in line [| git              |        |        |        |]
[WARNING] didn't find dep in line [| rsync            |        |        |        |]
[WARNING] didn't find dep in line [| libgcc                                                                           |        |        |        | AIX and Solaris only     |]
Switched to a new branch 'deptables-2021-01-13_14_03_25_765604'
[deptables-2021-01-13_14_03_25_765604 236620b] Update dependency tables
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 596 bytes | 99.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
remote: 
remote: Create a pull request for 'deptables-2021-01-13_14_03_25_765604' on GitHub by visiting:
remote:      https://github.com/Lex-2008/buildscripts/pull/new/deptables-2021-01-13_14_03_25_765604
remote: 
To github.com:Lex-2008/buildscripts.git
 * [new branch]      deptables-2021-01-13_14_03_25_765604 -> deptables-2021-01-13_14_03_25_765604
[INFO] SLACK: <@con>: Dependency tables:
PR: https://github.com/cfengine/buildscripts/pull/794
<@cf-bottom>

Note that created PR doesn't change anything, since tables were already updated by Tom in https://github.com/cfengine/buildscripts/pull/790

cf-bottom commented 3 years ago

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/6014/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-6014/

Lex-2008 commented 3 years ago

[WARNING] didn't find dep in line [| lcov             | 1.14   | 1.14   | 1.14   |]
this line looks correct and should be parsed, right?

Not really. All other dependencies always have URL in them, while these three come from Build dependencies table and don't have URLs.

cfengine / cf-bottom

Adapted Tom to new deptables location and layout #59