search

cfengine / design-center

CFEngine community-contributed content
http://cfengine.com/
Other
80 stars 68 forks source link

Remove testing code (dc_test, not_test, exec_prefix, path_prefix) #448

Closed tzz closed 9 years ago

tzz commented 9 years ago

This is for all enterprise_compatible sketches. I didn't bump their versions.

The API and cf-sketch.pl tools will still generate the test environment key, but it won't be used by any sketches. The API's self test command will need to be modified or removed.

The docs haven't been updated.

I think this is a good idea. Better to test inside Docker or with other tools than to burden sketches and authors with the testing framework. It reduces code line count and complexity.

tzz commented 9 years ago

@nickanderson please consider this and let me know if I should pursue it further.

nickanderson commented 9 years ago

I think removing all of the exec prefix stuff is a good idea it makes the policy much harder to read.

tzz commented 9 years ago

Cool, thanks. So should I proceed with the rest of the tasks I mentioned? I didn't want to pursue this if it wasn't going to be acceptable...

estenberg commented 9 years ago

Oh yes, really nice! This clarifies things a lot.

tzz commented 9 years ago

Can this be merged as is or is it missing something?