Incorrect make call on line 36 of Makefile

BasementTrix commented 6 years ago

Currently, line is:

cd tools/cf-sketch; make install-full PREFIX=$(DESTDIR) GIT=$(GIT)

Should be:

cd tools/cf-sketch; $(MAKE) install-full PREFIX=$(DESTDIR) GIT=$(GIT)

Causes build to fail where 'make' on the $PATH is not GNU make.

Or, in 'git diff' form:

--- a/Makefile +++ b/Makefile @@ -33,6 +33,6 @@ install-sketches: /bin/cp -rp ./sketches $(DESTDIR)/

install-tools:

cd tools/cf-sketch; make install-full PREFIX=$(DESTDIR) GIT=$(GIT)
cd tools/cf-sketch; $(MAKE) install-full PREFIX=$(DESTDIR) GIT=$(GIT)

install: install-sketches install-tools

tzz commented 6 years ago

@nickanderson YES

nickanderson commented 6 years ago

It is in master

https://github.com/cfengine/design-center/blob/234baabf3a342815bc59f1c4b7157aa95c6c3d82/Makefile#L22

Did I miss something else?

On Mon, Aug 13, 2018 at 1:49 PM Trix Farrar notifications@github.com wrote:

Line 22: same problem for target "check"
cd tools/test; make api_selftest_junit NOIGNORE=1
should be cd tools/test; ${MAKE} api_selftest_junit NOIGNORE=1

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cfengine/design-center/issues/463#issuecomment-412624047, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMYkCxLf5B45Z7nAOiygAFSNu4Jwpjpks5uQcoogaJpZM4VhH4x .

cfengine / design-center

Incorrect make call on line 36 of Makefile #463