search

cferdinandi / atomic

A tiny, Promise-based vanilla JS Ajax/HTTP plugin with great browser support.
MIT License
540 stars 78 forks source link

Push current version to npm #72

Closed brandonkal closed 5 years ago

brandonkal commented 5 years ago

Please push the current version to npm and update the readme to suggest using the jsdelivr npmjs urls over the /gh/ urls as they recommend.

Thanks for this library!

cferdinandi commented 5 years ago

I made a hard break with v4.x away from NPM.

With dozens of OSS projects to maintain, adding another step to the deploy process is something I just constantly forget to do, etc.

Once GitHub Actions rollout (which can be used to automate NPM deployment) I will revisit.

Log1x commented 5 years ago

You haven't happened to get access to GitHub Actions beta yet, have you? You have some seriously great libraries– I really hope to see them all on npm soon..

cferdinandi commented 5 years ago

Thanks for the bump, @Log1x! I have gotten access, actually!

I got a bit stuck on how to set things up. I believe I need to add my NPM credentials to an environment variable somewhere.

If you've seen any tutorials around this, I'm all ears. I'd love to set this up!

Log1x commented 5 years ago

I haven't worked with them personally yet, but it looks like GitHub has provided an action specifically for npm: https://github.com/actions/npm

Thanks a lot!

cferdinandi commented 5 years ago

The token piece (and specifically how not to expose that publicly) are what's got me stuck right now. Soon as I figure that out, I'm golden!

cferdinandi commented 5 years ago

Oh, here we go! https://medium.com/devopslinks/automate-your-npm-publish-with-github-actions-dfe8059645dd

Log1x commented 5 years ago

I wasn't entirely sure how the actions worked– I was wrongly assuming it was a local ENV var. The above looks like it will integrate nicely!

Another project that might be worth a global install is np.

cferdinandi commented 5 years ago

Yet, I can't get it to work. Just pushed a new version with updated tag and... nothing on NPM. Not sure what's going on here... :(

Log1x commented 5 years ago

Does the action namespace it (e.g. @cferdinandi/atomic)? I know there's another atomic package that already exists, could be clashing and failing silently or something.

cferdinandi commented 5 years ago

it's atomicjs there. I updated the name in package.json first. I must have the action messed up.

cferdinandi commented 5 years ago

Ok, this was REALLY convoluted, but I think I've got it working, finally. Thanks for the push