cferdinandi / kraken

A lightweight, mobile-first boilerplate for front-end web developers.
http://cferdinandi.github.io/kraken
MIT License
806 stars 81 forks source link

@extend issue with _grid.scss on line 97 #275

Closed escapehatch closed 5 years ago

escapehatch commented 6 years ago

https://github.com/cferdinandi/kraken/blob/9612f781ad5d92f318114de89a08682e51c3eaa2/src/sass/components/_grid.scss#L97

CodeKit shows Libsass: Error: You may not @extend an outer selector from within @media. You may only @extend selectors within the same directive. From "@extend %grid-with-padding" on line 110 of kraken-8/src/sass/components/_grid.scss on line 97 of kraken-8/src/sass/components/_grid.scss

 %grid-with-padding {

--^

euro commented 6 years ago

Seeing the same thing using plain gulp/node workflow (not CodeKit).

`kraken-master $ gulp [21:15:55] Using gulpfile ~/WebServer/kraken-master/gulpfile.js [21:15:55] Starting 'lint:scripts'... [21:15:55] Starting 'clean:dist'... [21:15:55] Finished 'clean:dist' after 6.32 ms [21:15:55] Starting 'build:scripts'... [21:15:55] Starting 'build:styles'... [21:15:55] Starting 'build:images'... [21:15:55] Starting 'build:svgs'... [21:15:55] Starting 'clean:docs'... [21:15:55] Finished 'clean:docs' after 14 ms [21:15:55] Starting 'copy:assets'... [21:15:55] Finished 'lint:scripts' after 141 ms [21:15:55] Finished 'build:scripts' after 126 ms [21:15:55] Finished 'build:images' after 277 ms [21:15:55] Plumber found unhandled error: Error in plugin 'gulp-sass' Message: src/sass/components/_grid.scss Error: You may not @extend an outer selector from within @media. You may only @extend selectors within the same directive. From "@extend %grid-with-padding" on line 110 of src/sass/components/_grid.scss on line 97 of src/sass/components/_grid.scss

 %grid-with-padding {

--^

Details: status: 1 file: /Users/gregbeatty/WebServer/kraken-master/src/sass/components/_grid.scss line: 97 column: 3 formatted: Error: You may not @extend an outer selector from within @media. You may only @extend selectors within the same directive. From "@extend %grid-with-padding" on line 110 of src/sass/components/_grid.scss on line 97 of src/sass/components/_grid.scss

 %grid-with-padding {

--^

messageFormatted: src/sass/components/_grid.scss

Error: You may not @extend an outer selector from within @media. You may only @extend selectors within the same directive. From "@extend %grid-with-padding" on line 110 of src/sass/components/_grid.scss on line 97 of src/sass/components/_grid.scss

 %grid-with-padding {

--^

messageOriginal: You may not @extend an outer selector from within @media.

You may only @extend selectors within the same directive. From "@extend %grid-with-padding" on line 110 of src/sass/components/_grid.scss

relativePath: src/sass/components/_grid.scss`
cferdinandi commented 5 years ago

This should now be fixed with v8.0.3

escapehatch commented 5 years ago

Hi Chris,

great. Thank you.

Best, Tom

On 19 Nov 2018, at 9:01 pm, Chris Ferdinandi notifications@github.com wrote:

Closed #275 https://github.com/cferdinandi/kraken/issues/275.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cferdinandi/kraken/issues/275#event-1975741443, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHeQXkcaZ2wbCOjCcijbI7YfX2fKqGDks5uwxwdgaJpZM4WLkF8.