Fixed issue with settings callback not being called

cferdinandi / tabby

Lightweight, accessible vanilla JS toggle tabs.

MIT License

602 stars 73 forks source link

Fixed issue with settings callback not being called #53

Closed jaukia closed 8 years ago

jaukia commented 8 years ago

There was a bug that prevented callback in settings being called, because of a local variable "settings" having the same name (the variable is instantiated in the beginning of the scope). This fixes the bug.

cferdinandi commented 8 years ago

Hey dude, good catch! Thanks for submitting a PR for this one!

I just submitted an updated PR with a new semver number (and added in a CONTRIBUTE.md file, which I've been meaning to do for a while). I'm going to close this out since your changes plus the rebuild are captured in https://github.com/cferdinandi/tabby/pull/54.

Thanks again!