fix: preventing removal id

cferdinandi / tabby

Lightweight, accessible vanilla JS toggle tabs.

MIT License

598 stars 73 forks source link

fix: preventing removal id #76

Closed senja006 closed 7 years ago

senja006 commented 7 years ago

In some cases, the removal took place id. As a result, the tab could not be opened

cferdinandi commented 7 years ago

Hey there, thanks for this. How can I reproduce this issue myself? I'd like to see it in action before accepting this PR.

senja006 commented 7 years ago

The action can be viewed here http://login-cash.yarkevich.ru/. Example http://login-cash.yarkevich.ru/example.mov

cferdinandi commented 7 years ago

It looks like you need to add the data-tab attribute to the Личный кабинет/Personal Area button in the second tab. That seems to be what's causing the issue.

Can you see if that fixes the issue first?

senja006 commented 7 years ago

Thank you. It works now

cferdinandi commented 7 years ago

👍