search

cferdinandi / tabby

Lightweight, accessible vanilla JS toggle tabs.
MIT License
598 stars 73 forks source link

Improve accessibility with ARIA attributes #96

Closed slavanga closed 5 years ago

slavanga commented 6 years ago

Tabby should use ARIA attributes to improve accessibility.

Inspiration:

cferdinandi commented 6 years ago

While I agree that tabby needs some a11y improvements, and ARIA may certainly be part of that, I'd like to also point out that:

  1. Foundation has a terrible track record with accessibility, and...
  2. ARIA is not strictly necessary for good accessibility.

Digging into point 2 for a minute: generally speaking, when HTML semantics alone provide sufficient accessibility, it's detrimental to also add ARIA. It should be used when and only when HTML and CSS alone do not provide sufficient intent and wayfaring to individuals using assistive devices like screenreaders.

So with that in mind, can you identify any specific aspects of Tabby that are currently inaccessible or do not work for users with assistive devices? If so, I'd be happy to address them.

cferdinandi commented 5 years ago

A complete rewrite with proper accessibility, roles, etc. is being released tomorrow

cferdinandi commented 5 years ago

Done: https://github.com/cferdinandi/tabby/releases/tag/v12.0.0