cferdinandi / tabby

Lightweight, accessible vanilla JS toggle tabs.
MIT License
598 stars 73 forks source link

Keyboard navigation issue #97

Closed klues closed 5 years ago

klues commented 6 years ago

I use tabby in my project with currently four tabs and found out that there is an issue with keyboard navigation if there are navigateable items on the tabs. See the following example: https://jsfiddle.net/eseac98a/7/

I fixed the problem with display:none and display:block in the css, see: https://jsfiddle.net/eseac98a/9/

cferdinandi commented 6 years ago

This is how tabby was designed to work, and at the time, I thought this was better for accessibility. After having some conversations with accessibility expert @scottaohara, though, I've realized I'm 100% wrong about this approach.

I'll fix this in a future release. No target date for completion.

cferdinandi commented 5 years ago

Quick update: a complete rewrite of this is coming tomorrow.

cferdinandi commented 5 years ago

v12 is now live and fixes this issue: https://github.com/cferdinandi/tabby/releases/tag/v12.0.0