search

cffdrs / cffdrs_py

Python Module for CFFDRS
GNU General Public License v2.0
6 stars 3 forks source link

Can we integrate the FWI code from Liz Ramsey! #1

Open SIBeckers opened 1 year ago

SIBeckers commented 1 year ago

Just want to flag that Liz has a working version of fwi code and also has overwintering and some other stuff. I'm sure we can get it.

BadgerOnABike commented 1 year ago

https://github.com/lizramsey/Medium_FWI

Repo here, going to assist with the review also.

SIBeckers commented 1 year ago

Guess I should get names correct :)

piyushnz commented 1 year ago

Is the plan to merge these implementations to have one code to rule them all?

Note that one difference between the R code and the Python code that Liz has worked on is the treatment of latitude adjustments which are in bands in the R code and are continuous in the Python code. Other than that they should agree...

BadgerOnABike commented 1 year ago

Sounds like an upgrade for the R code is needed :)

fluxium commented 1 year ago

Looks like https://github.com/lizramsey/Medium_FWI was removed or set to private. Any updates on this issue?