CRAN - Githubissues

cfhammill / lenses

Elegant Data Manipulation with Lenses

https://cfhammill.github.io/lenses

Other

27 stars 4 forks source link

CRAN #8

Closed cfhammill closed 2 years ago

cfhammill commented 6 years ago

Submission in progress. Auto checks all passed. Waiting on manual review

cfhammill commented 6 years ago

Fortunately we have been rejected. Uwe wants us to fix up the description and add a bit more explanation. This is fortunate because we can now change the name in time for first release

cfhammill commented 6 years ago

Yet another rejection, this time for slightly more substantive reasons. Uwe has requested that we:

[x] Single quote software names, e.g. haskell, further suggesting we capitalize the H.
[x] Provide paper references or websites in the description. This should be fine, we'll just include Jules' blog and a link to the lens package.
[x] Provide more code examples in our docs.

Obviously number three is the most serious. But a reasonable request.

I think we're fortunate again here, our first release will have map_l which is kind of necessary.

cfhammill commented 6 years ago

A few more docs needed, finished all base-lenses.R (except unlist_l), all array-lenses.R, all dataframe-lenses.R (except transpose_l), all lens.R (except oscope but not bothering there). Remains to be done, verbs.R and text-lenses.R

cfhammill commented 5 years ago

@bcdarwin Any outstanding (high-priority) issues before resubmission?

bcdarwin commented 5 years ago

Nothing on my end ... what about version %>% over(last_l, x ~ x + 1) ?

cfhammill commented 5 years ago

Good call. I want to finish the filepath lenses, but oh goodness are they ever corner-cases galore, the other part of me wants to scrap them all and save them for a future release.

Points to your idea - just write a parser for filepaths, regex is too tricky.