search

cfilipov / MuscleBook

[ABANDONED] Muscle Book is an iOS workout tracker for strength training and body building.
GNU General Public License v3.0
42 stars 18 forks source link

Bodyweight not recorded on bodyweight exercises #20

Closed cfilipov closed 8 years ago

cfilipov commented 8 years ago

A recent commit (0f596c542889dba3a696fcf7b0efcd14301e5f56) added the ability to specify required fields in the exercise schema. One example of this is that exercises like "Pull Up" now only display fields for reps and bodyweight in the data entry screen, whereas "Weighted Pull Up" will display reps, bodyweight and weight (for added weight) fields.

For some reason, bodyweight numbers are not being recorded. Entering the data succeeds, but going back to view the data shows a blank space in the bodyweight field.

I don't know if this is because the data isn't being recorded in the db, or if it's because it's just not being displayed (I suspect the later due to the lack of % calculations).

I haven't had time to look at this yet but tracking it so I don't forget in the next version. It's probably a simple issue of forgetting to read that entry field into the input struct.

cfilipov commented 8 years ago

Fixed this already but forgot to close the issue.