search

cfillion / reapack-index

Package indexer for git-based ReaPack repositories
GNU General Public License v3.0
28 stars 1 forks source link

Reapack-index doesn't warn you of missing name #10

Closed myrrc closed 1 year ago

myrrc commented 1 year ago

Hi! While importing this file I once got an error "The received file is invalid: invalid name".

The source of the problem was that reapack-index doesn't warn you of missing repository name (I didn't use '--no-strict').

Maybe you could set the '-n' parameter as mandatory?

Related to https://github.com/cfillion/reapack/pull/63

cfillion commented 1 year ago

reapack-index already issues a warning:

$ reapack-index
warning: This index is unnamed. Run the following command to set a name of your choice:
  reapack-index --name 'FooBar Scripts'
Indexing commit 1 of 1 (100%)...
Nothing to do!
myrrc commented 1 year ago

I'm using Reapack v1.2.3 from RubyGems, unfortunately, this version doesn't warn of unnamed indices

cfillion commented 1 year ago

It should, this warning has been there since v1.0beta3 (although wording changed a bit over time):

screenshot

myrrc commented 1 year ago

So I didn't manage to get the installed version to print the warning. However, re-installing the same version from RubyGems fixed the issue. Thanks.

cfillion commented 1 year ago

That's very weird! Let me know if it happens again...