cfinke / Feed-Sidebar

The Feed Sidebar is an extension for Firefox that displays the items from your Live Bookmarks in the sidebar.
https://addons.mozilla.org/en-US/firefox/addon/4869/
GNU General Public License v2.0
5 stars 3 forks source link

Invalid characters in feed item title and description #14

Closed cfinke closed 13 years ago

cfinke commented 13 years ago

What steps will reproduce the problem?

Subscribe http://servis.idnes.cz/rss.asp?c=ekonomikah

What is the expected output? What do you see instead?

Expected: correct national characters in feedsidebar Got: "square" instead of every non-ascii7 character

What version of the product are you using? On what operating system?

Latest 3.1.6 or 3.2pre2 on WinXP in FF 3.0.7

Please provide any additional information below.

The issue is caused by wrong content type sent by the server. Everything works great if the content type is application/xml - all encodings are handled correctly (utf-8, windows-1250, iso-8859-2). But if the server wrongly sends text/html it seems that XMLHttpRequest messes it up.

Solutions for this issue is quite easy: patch function doLoadNextFeed in feed_getter.js with one line to override the content type.

try {
    req.open("GET", url, true);

Issue imported from Google Code Author: petr.smejkal@seznam.cz Published: 2009-03-23T21:50:10.000Z Status: Fixed Link: http://code.google.com/p/feedsidebar/issues/detail?id=15

cfinke commented 13 years ago

Fixed in r128.


Comment imported from Google Code Author: cfinke Published: 2010-02-10T02:46:10.000Z Link: http://code.google.com/p/feedsidebar/issues/detail?id=15#c1