search

cfinke / Feed-Sidebar

The Feed Sidebar is an extension for Firefox that displays the items from your Live Bookmarks in the sidebar.
https://addons.mozilla.org/en-US/firefox/addon/4869/
GNU General Public License v2.0
5 stars 3 forks source link

Use menupop up instead of popup for Fx 4 compatibility #70

Closed cfinke closed 13 years ago

cfinke commented 13 years ago

popup no longer has the proper styling applied on mozilla-central (the background is clear and there are some other issues). It is deprecated and should be replied with "menupopup" which is functionally equivalent (according to https://developer.mozilla.org/en/XUL/popup). See https://developer.mozilla.org/en/Firefox_4_for_developers#Miscellaneous_XUL_changes for more information.

I'll try to make a patch tonight if I have time, although a find-replace of "<popup " --> "<menupopup " and "</popup>" to "</menupopup>" should fix it. And seems the change is limited to only sidebar.xul.

Issue imported from Google Code Author: clokep Published: 2010-08-10T20:28:34.000Z Status: Fixed Link: http://code.google.com/p/feedsidebar/issues/detail?id=71

cfinke commented 13 years ago

That did fix it; thanks for the heads-up.

Comment imported from Google Code Author: cfinke Published: 2010-08-11T02:27:09.000Z Link: http://code.google.com/p/feedsidebar/issues/detail?id=71#c1