search

cfinke / Feed-Sidebar

The Feed Sidebar is an extension for Firefox that displays the items from your Live Bookmarks in the sidebar.
https://addons.mozilla.org/en-US/firefox/addon/4869/
GNU General Public License v2.0
5 stars 3 forks source link

Feed Sidebar menuitem acceltext still says Ctrl+Shift+F #87

Closed Quicksaver closed 10 years ago

Quicksaver commented 10 years ago

It still says Ctrl+Shift+F in all locales, which is wrong since you changed it to Y. BTW, I was going to create a pull but I saw that you had a double keyset element, one for the F accesskey in the dtd, and another that always overrides it with a hardcoded Y, and got confused so I thought it was better to leave it alone.

Quicksaver commented 10 years ago

And it also says that on OSX, maybe it should say "⇧⌘Y" instead (copy-paste'ing that to a dtd entity or directly to the acceltext attribute works fine btw).

cfinke commented 10 years ago

Thanks for the feedback; I've fixed it and am uploading the change as 8.0.4.