search

cfis / activejob-locking

MIT License
30 stars 15 forks source link

Tests are non-determinate #2

Closed jeremywadsack closed 6 years ago

jeremywadsack commented 6 years ago

I was looking to extend this with another lock option (and submit a PR) but I have now spent several days trying to get the test suite to work and have not had any luck. It seems to fail different tests on different adapters, randomly. I got this hooked up to Travis (so I could run in a different environment) and that still fails.

I'm stumped about how to test this consistently. How do you make that work?

cfis commented 6 years ago

Yes, that is true. I spent some time on trying to fix but eventually moved on. Happy to take a pull request.

jeremywadsack commented 6 years ago

I couldn't figure this out.

Because of this I moved on to another activejob-traffic_control which seems to be the only ActiveJob-compatible locking gem that has a number of people using it. It also has a test suite that passes out-of-the box.

cfis commented 6 years ago

Ok, thanks.