search

cfjedimaster / HTML5ComicBookReader

A HTML5-based comic book reader.
33 stars 80 forks source link

Drag and drop not working #1

Open sgehrman opened 11 years ago

sgehrman commented 11 years ago

I drag and drop a cbz file on the window on Chrome and it 'downloads' the file. Not sure why it doesn't open it. Same thing happens on Kuykendal's fork.

Deevad commented 11 years ago

Same experience here

cfjedimaster commented 11 years ago

I fixed this in my online demo a while ago, but forgot to update the github repo. I will, but for now, see my updates on the blog: http://www.raymondcamden.com/index.cfm/2012/5/29/Building-an-HTML5-Comic-Book-Reader

Specifically look at the update right on top.

Deevad commented 11 years ago

Thanks ! Yep , I confirm your online version works perfectly with *.cbz. Good work !

cfjedimaster commented 11 years ago

Ok, I'm confused. I checked the code here and it works fine w/ latest Chrome. It includes the fix I mentioned in the blog post. But you said the code here did not work, but the code from my blog did. Can you try again with the code from the repo?

Deevad commented 11 years ago

Chrome Version 28.0.1500.52 on Linux Mint KDE 14 here and after a clean 'git clone' , still the issue . After a D&D on HTML5ComicBookReader/index.html page ( copied locally on my home folder ) ; chrome only propose me to download the *.cbz file. Same with an incognito tab ( I tested this to exclude the possibility of a local extension bug )

cfjedimaster commented 11 years ago

Is 28 the dev channel? I'm on 27 - can you try that? As far as I know, the JS file on my blog is the same as source control. Same fix, same # of lines.

Deevad commented 11 years ago

Probably something for Linux made by Google ; I just downloaded here the Chrome installer for Ubuntu based system with default package , it's install a repository. I can't really test older package, as the package management is done automatically from my O.S. and new version come bundled into system update.

The issue is probably a permission issue with local files on Linux. I'll try to host it on a random server and retest.

Deevad commented 11 years ago

I just tested, it works here on my remote server, so it's defintely a behavior setup of Chrome in regards local files on Linux ; or D&D protocol on this platform from local to chrome. So, no need to fix ; thanks for your time and for sharing the code. ( note : I create graphic novel : as http://www.davidrevoy.com/article117/l-heritage-en-couleur , and I'm looking for various hosting solution ; as the one of hosting only a *.cbz file to propose for Download, or for viewing ... :-) I also study PDF as everybrowser has a built-in one nowaday . )

cfjedimaster commented 11 years ago

Wow - that's incredible. So you are looking for a platform to share it. I assume more in depth than just "scroll down". Right?

On Sun, Jun 23, 2013 at 4:06 PM, Deevad notifications@github.com wrote:

I just tested, it works here on my remote server, so it's defintely a behavior setup of Chrome in regards local files on Linux ; or D&D protocol on this platform from local to chrome. So, no need to fix ; thanks for your time and for sharing the code. ( note : I create graphic novel : as http://www.davidrevoy.com/article117/l-heritage-en-couleur , and I'm looking for various hosting solution ; as the one of hosting only a *.cbz file to propose for Download, or for viewing ... :-) I also study PDF as everybrowser has a built-in one nowaday . )

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/HTML5ComicBookReader/issues/1#issuecomment-19881518 .

Raymond Camden, Adobe Developer Evangelist

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: cfjedimaster

Deevad commented 11 years ago

I'm an artist; not a scripter/coder ( thats why I'm exploring all 'comic viewer' on GitHub and found your project ). I look only for a way enhance my personnal website at the moment and share my free comics with a updated technology ; minimising weight of download and saving my server disk space ( .cbz is attractive here , it can be viewed and downloaded ) , saving bandwith ( In this case, the viewer require to have the whole .cbz to extract ; so maybe I'll look for splitting page and load them dynamicly while scrolling ) , rule for tablet and phone low screen maybe ... etc... All in all , I like to read comic on screen and scroll infinitely ( especially on tablet ) . I'm still experimentating :-)

cfjedimaster commented 11 years ago

Interest - let me know how you progress (feel free to email me directly).

On Mon, Jun 24, 2013 at 3:37 AM, Deevad notifications@github.com wrote:

I'm an artist; not a scripter/coder ( thats why I'm exploring all 'comic viewer' on GitHub and found your project ). I look only for a way enhance my personnal website at the moment and share my free comics with a updated technology ; minimising weight of download and saving my server disk space ( .cbz is attractive here , it can be viewed and downloaded ) , saving bandwith ( In this case, the viewer require to have the whole .cbz to extract ; so maybe I'll look for splitting page and load them dynamicly while scrolling ) , rule for tablet and phone low screen maybe ... etc... All in all , I like to read comic on screen and scroll infinitely ( especially on tablet ) . I'm still experimentating :-)

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/HTML5ComicBookReader/issues/1#issuecomment-19895023 .

Raymond Camden, Adobe Developer Evangelist

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: cfjedimaster