search

cfjedimaster / brackets-jshint

Adds JSHint support to Brackets
MIT License
131 stars 41 forks source link

.jshintrc support #5

Closed joggienl closed 11 years ago

joggienl commented 11 years ago

As an user I would like to see support for a .jshintrc file so I can define all my JSHint rules on a project base level.

Is it possible in this current extension to implement?

cfjedimaster commented 11 years ago

Is it possible to implement? Um, yes. I'm not sure if you mean, "Does it work now", or, "Can you add it." No to the first, yes to the second. :)

joggienl commented 11 years ago

Thanks for your quick reply! I noticed that it doesn't work right now (because I have a .jshintrc file). So the question indeed is: Can you add it. Thanks!

cfjedimaster commented 11 years ago

I'll look into it for sure.

On Sat, May 18, 2013 at 3:55 PM, Jogchum Koerts notifications@github.comwrote:

Thanks for your quick reply! I noticed that it doesn't work right now (because I have a .jshintrc file). So the question indeed is: Can you add it. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/cfjedimaster/brackets-jshint/issues/5#issuecomment-18107823 .

Raymond Camden, Adobe Developer Evangelist

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: cfjedimaster

cfjedimaster commented 11 years ago

This is done. My implementation is not good in that it checks for the file on every parse, but I needed to start someplace. And it works. Which is cool!

joggienl commented 11 years ago

Hi, Checking on every parse does mean that changes to the .jshintrc file are in effect immediately! So for now not to bad at all I guess.

Have you checked on globals support? In my quick check it didn't work as expected.

Looks good so far! Thanks for the work :+1:

cfjedimaster commented 11 years ago

Confirmed - this was the dumb bug you found. Fixed. :)

joggienl commented 11 years ago

Love it! Works excellent!