search

cfjedimaster / brackets-jshint

Adds JSHint support to Brackets
MIT License
130 stars 41 forks source link

Bump to JSHint 2.5.10 #65

Closed mitchellmebane closed 9 years ago

mitchellmebane commented 9 years ago

This simply updates to JSHint 2.5.10 and bumps the plugin version number. Lots of bug fixes.

cfjedimaster commented 9 years ago

Thank you for updating the package.json file too - most contributors forget that. :)

mitchellmebane commented 9 years ago

Heh, don't say thanks too soon. Looks like I somehow tested the wrong local branch, and the JSHint update might have broken something...

cfjedimaster commented 9 years ago

Ugh - and I'm ashamed to say I didn't even test - I just assumed it was ok. ;) Got a quick fix?

On Wed, Dec 10, 2014 at 3:50 PM, Mitchell Mebane notifications@github.com wrote:

Heh, don't say thanks too soon. Looks like I somehow tested the wrong local branch, and the JSHint update might have broken something...

— Reply to this email directly or view it on GitHub https://github.com/cfjedimaster/brackets-jshint/pull/65#issuecomment-66530462 .

Raymond Camden, Web Developer for Adobe

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden

mitchellmebane commented 9 years ago

No. JSHint is blowing up with "Cannot find module 'jshint'", and the stack trace looks like it's being triggered by the JSHINT = require('jshint').JSHINT; at the end of jshint.js itself. It might be related to the upgrade from Browserify 5.x to 6.x made in JSHint 2.5.7, but I'm not sure yet.

Want me to submit a pull request for a revert?

cfjedimaster commented 9 years ago

if you could please

On Wed, Dec 10, 2014 at 4:03 PM, Mitchell Mebane notifications@github.com wrote:

No. JSHint itself is blowing up with "Cannot find module 'jshint'", and the stack trace looks like it's being triggered by the JSHINT = require('jshint').JSHINT; at the end of jshint.js itself. It might be related to the upgrade from Browserify 5.x to 6.x made in JSHint 2.5.7, but I'm not sure yet.

Want me to submit a pull request for a revert?

— Reply to this email directly or view it on GitHub https://github.com/cfjedimaster/brackets-jshint/pull/65#issuecomment-66532642 .

Raymond Camden, Web Developer for Adobe

Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden

mitchellmebane commented 9 years ago

OK, I submitted the revert.

Looks like https://github.com/jshint/jshint/issues/1993 may be the root cause.